Add init_worker_code for code that runs once per worker#85
Add init_worker_code for code that runs once per worker#85maleadt merged 9 commits intoJuliaTesting:mainfrom
init_worker_code for code that runs once per worker#85Conversation
|
We did intentionally removed this functionality at some point during a refactor. Would it make sense to move the GPUArraysTest instead into a package? |
With the idea being that a separate package would be precompiled so loading the precompiled test suite for every test would introduce less overhead? I think that would add a significant amount of friction for contributing to GPUArrays. Maybe I de-emphasize it in the docs and make clear that |
|
@giordano I've addressed your feedback. It should be more clear that this is only really meant for situations with long-running initialization code, and I fixed the test that initially didn't test anything |
It would not need to be a seperate repository, and I don't even think we would need to register it. |
|
Should I bump to 2.2 here or is it better as a separate commit/PR? |
|
You can bump here |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
christiangnrd
force-pushed
the
initwrkr
branch
from
63a91ba to
d69145f
Compare
|
Fixed up and added a note in the documentation |
4 participants
The GPUArrays testsuite takes at least 3s to load. It saves a lot of time to only load it once per worker instead of once per test especially in the memory constrained runners that are 7-8GB Mac Minis
Non-breaking